Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal reproducible code draft #73

Merged
merged 14 commits into from
Nov 23, 2024
Merged

Conversation

kaijagahm
Copy link
Collaborator

Full draft of the minimal reproducible code lesson. Includes full lesson structure.

Notes:

  • I dumped a giant script at the beginning that includes the code in the researcher narrative up through the part that was assigned to this episode. I realize this is overwhelming and gross, and we can discuss changes to it.

    • @peterlaurin and I discussed this today and thought that it was generally a good approach, rather than trying to work the code in gradually, since we're not actually trying to teach coding in this episode. I still have some reservations, but let's roll with it for now.
    • I wanted to use code folding, and tried to, but it didn't work. Asking in Carpentries Slack about how to fix this. If we can't get it to work, we should include this as a separate script that users have to download.
    • I do think it's important to have them all working with the exact same script version at least for this part.
  • Critically, this is still missing content for the exercises, and that's largely because the script itself does not contain enough errors. Need to introduce some errors into the script, especially in the later portions (modeling, plotting, answering research questions) so that we can then refer to those in the lesson.

  • Time estimates are probably way off.

  • @peterlaurin and @xortizross there are some spots indicated here for you to add references back to your own episodes

Copy link

github-actions bot commented Nov 23, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/R-help-reprexes/compare/md-outputs..md-outputs-PR-73

The following changes were observed in the rendered markdown documents:

 4-minimal-reproducible-data.md |  62 +++---
 5-minimal-reproducible-code.md | 434 ++++++++++++++++++++++++++++++++++++++++-
 6-asking-your-question.md      |   8 +-
 md5sum.txt                     |   8 +-
 4 files changed, 466 insertions(+), 46 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-11-23 01:36:51 +0000

Copy link
Collaborator

@peterlaurin peterlaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I did not check all the renv stuff but it seems to be passing the checks so I think we can just let it be?

@peterlaurin peterlaurin merged commit d8b86da into main Nov 23, 2024
3 checks passed
@peterlaurin peterlaurin deleted the minimal-reproducible-code-draft branch November 23, 2024 01:38
github-actions bot pushed a commit that referenced this pull request Nov 23, 2024
github-actions bot pushed a commit that referenced this pull request Nov 23, 2024
Auto-generated via `{sandpaper}`
Source  : d8b86da
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-11-23 01:38:06 +0000
Message : Merge pull request #73 from carpentries-incubator/minimal-reproducible-code-draft

Minimal reproducible code draft -- Resolved discrepancy in yaml with md and Rmd
github-actions bot pushed a commit that referenced this pull request Nov 23, 2024
Auto-generated via `{sandpaper}`
Source  : d7c2a92
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-23 01:41:12 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : d8b86da
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-11-23 01:38:06 +0000
Message : Merge pull request #73 from carpentries-incubator/minimal-reproducible-code-draft

Minimal reproducible code draft -- Resolved discrepancy in yaml with md and Rmd
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Auto-generated via `{sandpaper}`
Source  : d8b86da
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-11-23 01:38:06 +0000
Message : Merge pull request #73 from carpentries-incubator/minimal-reproducible-code-draft

Minimal reproducible code draft -- Resolved discrepancy in yaml with md and Rmd
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Auto-generated via `{sandpaper}`
Source  : a832cb7
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-26 01:19:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : d8b86da
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-11-23 01:38:06 +0000
Message : Merge pull request #73 from carpentries-incubator/minimal-reproducible-code-draft

Minimal reproducible code draft -- Resolved discrepancy in yaml with md and Rmd
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Auto-generated via `{sandpaper}`
Source  : a832cb7
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-26 01:19:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : d8b86da
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-11-23 01:38:06 +0000
Message : Merge pull request #73 from carpentries-incubator/minimal-reproducible-code-draft

Minimal reproducible code draft -- Resolved discrepancy in yaml with md and Rmd
xortizross added a commit that referenced this pull request Dec 3, 2024
commit 04fc52c
Merge: 66501ae ff995ea
Author: Xochitl Ortiz-Ross <[email protected]>
Date:   Tue Dec 3 14:04:57 2024 -0800

    Merge pull request #79 from carpentries-incubator/peter_edits

    changed relative path to load data

commit ff995ea
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 14:01:18 2024 -0800

    changed relative path to load data

commit 66501ae
Merge: b2ef676 c7d87b9
Author: Xochitl Ortiz-Ross <[email protected]>
Date:   Tue Dec 3 13:34:33 2024 -0800

    Merge pull request #78 from carpentries-incubator/peter_edits

    added identify the problem episode for review, Dec2024. Changed to Rm…

commit c7d87b9
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:44:26 2024 -0800

    removed open tag for carpentries

commit d419691
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:35:55 2024 -0800

    fixed further bugs

commit ad93365
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:19:41 2024 -0800

    fixed some last-minute R bugs

commit b2ef676
Merge: d8b86da d82aa3b
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:04:53 2024 -0800

    Merge pull request #77 from carpentries-incubator/xochitl_edits

    small edits

commit c1af304
Merge: 97eed2e d8b86da
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:01:33 2024 -0800

    Merge branch 'main' into peter_edits

commit 97eed2e
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 11:41:51 2024 -0800

    changed config to allow Rmd file for Peter's episode to run

commit 3a8d5b8
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 11:25:36 2024 -0800

    added identify the problem episode for review, Dec2024. Changed to Rmd to run R.

commit d8b86da
Merge: 96901a7 782e862
Author: peterlaurin <[email protected]>
Date:   Fri Nov 22 17:38:06 2024 -0800

    Merge pull request #73 from carpentries-incubator/minimal-reproducible-code-draft

    Minimal reproducible code draft -- Resolved discrepancy in yaml with md and Rmd

commit 782e862
Merge: 761d64f 96901a7
Author: peterlaurin <[email protected]>
Date:   Fri Nov 22 17:32:47 2024 -0800

    Merge branch 'main' into minimal-reproducible-code-draft

commit 96901a7
Merge: 5a23b4b fa15716
Author: peterlaurin <[email protected]>
Date:   Fri Nov 22 17:30:07 2024 -0800

    Merge pull request #65 from carpentries-incubator/kaijagahm-patch-3

    Update pull_request_template.md

commit 761d64f
Author: Kaija Gahm <[email protected]>
Date:   Fri Nov 22 17:00:33 2024 -0800

    Draft entire episode except for exercise content

commit 7ce1de3
Author: Kaija Gahm <[email protected]>
Date:   Fri Nov 22 10:58:19 2024 -0800

    fixed merge conflicts

commit 5a23b4b
Merge: 2335e86 ea9aecf
Author: Kaija Gahm <[email protected]>
Date:   Wed Nov 6 13:58:13 2024 -0800

    Merge pull request #69 from carpentries-incubator/xochitl_edits

    Xochitl edits

commit 449d69f
Merge: 5c85579 5210f72
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 23 14:57:12 2024 -0700

    fixed merge conflict

    Merge branch 'minimal-reproducible-code-draft' of github.com:carpentries-incubator/R-help-reprexes into minimal-reproducible-code-draft

    # Conflicts:
    #	episodes/5-minimal-reproducible-code.Rmd

commit 5c85579
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 23 14:29:36 2024 -0700

    15:00 end work session

commit 5210f72
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 23 14:29:36 2024 -0700

    2:30 end work session

commit 3ccd70e
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 23 14:03:56 2024 -0700

    sketching more exercises. reordered road map slightly.

commit 1817002
Author: Kaija Gahm <[email protected]>
Date:   Thu Oct 17 13:16:40 2024 -0700

    remembered ??fun shortcut for searching

commit 2265911
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 16 15:00:23 2024 -0700

    First draft of lesson text for the first part of the road map

commit c73f662
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 16 14:39:05 2024 -0700

    full episode outline

commit d95d7cc
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 16 14:26:29 2024 -0700

    Updated LOs for Ep5; moved {reprex} to Ep6

commit 8c33a45
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 16 14:13:58 2024 -0700

    Moved progress from last week to .Rmd from .md

commit fa15716
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 2 14:36:28 2024 -0700

    Update pull_request_template.md

    Just a simple update for our own use

commit 2ec2b16
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 2 14:03:26 2024 -0700

    First crack at narrative and a first exercise

commit dcb0d48
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 2 13:27:14 2024 -0700

    added LOs from google doc, and corresponding questions
---

::: questions
- Which part of my code is causing an error message or an incorrect result?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...is causing the problem?" -- a way to shorten the question?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh yes I like this.

- Which part of my code is causing an error message or an incorrect result?
- I want to make my code minimal, but where do I even start?
- How do I make non-reproducible code reproducible?
- How do I tell whether a code snippet is reproducible or not?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should go before the previous one

::: questions
- Which part of my code is causing an error message or an incorrect result?
- I want to make my code minimal, but where do I even start?
- How do I make non-reproducible code reproducible?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"How do I make my code reproducible?"

- Identify the step that is generating the error
- Implement a stepwise approach to make minimal code
- Edit a piece of code to make it reproducible
- Evaluate whether a piece of code is reproducible as is or not. If not, identify what is missing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I feel like this should go before the previous one... (first figure out whether it is reproducible, then fix it to make it so)

- How do I tell whether a code snippet is reproducible or not?
:::

::: objectives
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes!

episodes/6-asking-your-question.md Show resolved Hide resolved
renv/profiles/lesson-requirements/renv.lock Show resolved Hide resolved
renv/activate.R Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants